Changeset 627

Timestamp:

09/22/10 10:39:26 (3 years ago)

Author:

jose.brandao

Message:

Improving assistence.views.faq to use better the database and cache resources

Location:

trunk

Files:

• buildout.cfg (modified) (1 diff)
• opentrials/assistance/views.py (modified) (3 diffs)

trunk/buildout.cfg

@@ -33 +33 @@
     django-rosetta
     django-registration
+    django-reversion
 
 [django]

trunk/opentrials/assistance/views.py

@@ -9 +9 @@
 
 def faq(request):
-    questions = Question.objects.all().order_by('category', 'order')
+    """
+    ATTENTION: This view has a complexity of O(question * N * 2) on database load, because each
+    question does 1 or 2 calls to database to get question and category translations.
+
+    It is prepared to get questions including category fields at once SQL call and using cache
+    to get translations as far as possible.
+
+    If the questions quantity grow a lot, this logic should be replaced to something that gets
+    all translations from database at once.
+    """
+    questions = Question.objects.select_related('category').order_by('category', 'order')
 
     if len(questions) < 1:
@@ -19 +29 @@
             c = Category()
             try:
-                trans = question.translations.get(language__iexact=request.LANGUAGE_CODE)
+                #trans = question.translations.get(language__iexact=request.LANGUAGE_CODE)
+                trans = QuestionTranslation.objects.get_translation_for_object(request.LANGUAGE_CODE, question)
                 q.title = trans.title
                 q.answer = trans.answer
@@ -27 +38 @@
                 q = question
             try:
-                trans = question.category.translations.get(language__iexact=request.LANGUAGE_CODE)
+                #trans = question.category.translations.get(language__iexact=request.LANGUAGE_CODE)
+                trans = CategoryTranslation.objects.get_translation_for_object(request.LANGUAGE_CODE, question.category)
                 c.label = trans.label
             except CategoryTranslation.DoesNotExist: